Fix/private key cardano derivation - #193
Merged
Merged
Conversation
- Add PrivateKey.fromMnemonicCardano() using correct Cardano derivation - Deprecate fromMnemonic/derive/CardanoPath (uses secp256k1, wrong keys) - Add tests verifying match with Bip32PrivateKey derivation
- Add Transaction.extractBodyBytes to extract raw body from TX CBOR - Add hashTransactionRaw to hash raw body bytes without re-encoding - Fix signTx in seed/private-key wallets to use original bytes when input is hex - Fix signTxWithAutoFetch to pass original hex through to wallet - Fix lint in PrivateKey.CML.test.ts
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.