Implement tracing in the resource registry - #14
Conversation
| data Release m = Release { | ||
| runRelease :: m Bool | ||
| , releaseTracingInfo :: (Tracer m (Trace m), ResourceId, RegistryLabel) | ||
| } |
There was a problem hiding this comment.
Why isn't ResourceId and RegistryLabel part of Resource?
There was a problem hiding this comment.
Because the resource id and the registry label might be updated. If I have them here I can update them when transferring, otherwise I need to introduce a TVar on each resource
| newtype Release m = Release (m Bool) | ||
| data Release m = Release { | ||
| runRelease :: m Bool | ||
| , releaseTracingInfo :: (Tracer m (Trace m), ResourceId, RegistryLabel) |
There was a problem hiding this comment.
Why are we threading the tracer like this? Why not thread the (registry, resource) pair around?
There was a problem hiding this comment.
Same as below:
Then you cannot release a resource without its registry which will be annoying
|
|
||
| releaseResource :: Resource m -> m Bool | ||
| releaseResource Resource{resourceRelease = Release f} = f | ||
| releaseResource :: Monad m => Resource m -> m Bool |
There was a problem hiding this comment.
If you make this into releaseResource :: Monad m => Registry m -> Resource m -> m Bool you can use the tracer and the registry label from the registry itself?
There was a problem hiding this comment.
Then you cannot release a resource without its registry which will be annoying
9576092 to
280ca32
Compare
4fa2859 to
80da86a
Compare
bladyjoker
left a comment
bladyjoker
left a comment
There was a problem hiding this comment.
Looking forward to seeing metrics pop up in cardano-node! Let's open an issue in ouroboros-consensus to track this?
80da86a to
fd271cc
Compare
2 participants
No description provided.