Fold in leios testnet bugfixes from 20260708 stuck sync incident - #2112
Draft
nfrisby wants to merge 5 commits into
Draft
Fold in leios testnet bugfixes from 20260708 stuck sync incident#2112nfrisby wants to merge 5 commits into
nfrisby wants to merge 5 commits into
Conversation
It's ultimate Set EbHash, except it can be GC'd according to the SlotNo's that caused the EbHash to be in the set.
But the LeiosFetch logic didn't know that, so it eventually thought too many bytes were inflight even though they weren't, so it stopped sending any new requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes three bugs.
headerContainsLeiosCertfor the HFC, so we essentially never interepted MsgRollForward as an offer. I have no idea how the manual testing had done for that original PR didn't fail despite that.This code has been running on the testnet for 12 hrs now, without exhibiting the stuck syncs (which has been perfectly reliable prior to these).