Add json schema form custom editor support#536
Open
banduk wants to merge 2 commits intoIronclad:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a reusable JSON Schema form custom editor to the Rivet editor system, and fix code-editor persistence so debounced updates are flushed from the wrapper layer instead of during low-level editor teardown.
Summary
JsonSchemaFormEditorimplementation built onreact-jsonschema-formadditionalPropertiesediting, including add/remove controls and side-by-side key/value layoutWhy
This introduces a reusable way for plugins to expose structured configuration UIs from JSON Schema rather than requiring bespoke editor components for each node.
It also fixes a state-management issue in the code editor flow: the shared low-level Monaco component was previously used as a persistence point during teardown, which can be problematic because unmount does not always mean "commit". Moving the flush to the debounced wrapper keeps persistence logic in the layer that already owns update scheduling.
Example
A plugin node can use the new editor from
getEditors()like this: