feat: faster fvm flutter version detection#7213
Open
EscapeTo5D wants to merge 1 commit intoJanDeDobbeleer:mainfrom
Open
feat: faster fvm flutter version detection#7213EscapeTo5D wants to merge 1 commit intoJanDeDobbeleer:mainfrom
EscapeTo5D wants to merge 1 commit intoJanDeDobbeleer:mainfrom
Conversation
- Read Flutter version from .fvmrc file - Terminal command execution is slow for version detection
Owner
|
@EscapeTo5D will this file always be there? I feel a fallback to the old behaviour might still be a good idea. |
6a67260 to
85091a8
Compare
JanDeDobbeleer
requested changes
Mar 15, 2026
Owner
JanDeDobbeleer
left a comment
There was a problem hiding this comment.
See my previous comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Read Flutter version from
.fvmrcfile instead of runningfvm flutter --versioncommand for faster detection.Why
Terminal command execution is slow, reading file directly is much faster.
How
.fvmrcfile (primary).dart_tool/version(fallback).fvmfolder check