feat(segments): add Uno Platform support#7324
Open
ajpinedam wants to merge 4 commits intoJanDeDobbeleer:mainfrom
Open
feat(segments): add Uno Platform support#7324ajpinedam wants to merge 4 commits intoJanDeDobbeleer:mainfrom
ajpinedam wants to merge 4 commits intoJanDeDobbeleer:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new segment to display the Uno Platform SDK version by reading it from the global.json file's msbuild-sdks section. The implementation follows the established patterns for segments that parse JSON configuration files, properly handling commented JSON using jsonutil.StripComments.
Changes:
- Added Uno Platform segment that reads SDK version from
global.json - Registered the segment in all required locations with proper alphabetical ordering
- Added comprehensive documentation and test coverage including edge cases
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/segments/uno.go | Core implementation that parses global.json for Uno.Sdk version |
| src/segments/uno_test.go | Test coverage with 5 test cases including commented JSON handling |
| src/config/segment_types.go | Segment registration in gob.Register, const, and Segments map |
| website/docs/segments/cli/uno.mdx | User-facing documentation for the segment |
| website/sidebars.js | Added sidebar entry in alphabetical order |
| themes/schema.json | Added JSON schema definition for the segment |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR adds support for Uno Platform https://platform.uno. This new segment will display the Uno Platform version based on the information in global.json, which is very similar to what dotnet does.
Thank you!