Conversation
ea0e341 to
b3e9f63
Compare
src/shell/scripts/omp.zsh
Outdated
|
|
||
| # set secondary prompt | ||
| _omp_secondary_prompt=$($_omp_executable print secondary --shell=zsh) | ||
| _omp_secondary_prompt_plain=$($_omp_executable print secondary --shell=zsh --plain --escape=false) |
There was a problem hiding this comment.
this was needed to avoid ZHS markers that couldn't be re-encoded to mess up the secondary_prompt by directly injecting into the buffer. Made a change to be able to keep original behavior by default - see new changes.
b3e9f63 to
1d5d9a6
Compare
|
@JanDeDobbeleer The _omp_secondary_prompt_plain is used to re-inject prompt content w/o the zsh markers. It unfortunately sinks some control sequences (like coloring) but I didn't find an easy way to re-encode them. |
1d5d9a6 to
5dae27b
Compare
5dae27b to
25ce68b
Compare
|
fyi: rebased the changes and also providing the details about the behavioral change: Imagine you have:
Current behaviour is that if you have some old propts with transient_prompt and the actual input: and you hit an enter after "\", your prompt is immediately replaced with the transient prompt, e.g.: With the new property set to true, e.g.: the behavior will change. e.g. from the same initial state: if you hit enter, the prompt will not change to transient_prompt: only if you submit the command: |
|
@JanDeDobbeleer could you please have another look on the change? |
|
@kovjanos I've been crazy busy but I'll get to it latest next week! |
Prerequisites
Description
Previously while multiline command was typed the prompt changed to transient_prompt. If a multiline prompt was used with e.g. a single line transient_prompt, that caused the prompt replaced with transient prompt right after the first enter was hit after "\" in the multiline command.
With the changes the multiline prompt is kept until the multiline command is submitted.
multi-line entry and Ctrl-C interrupts.