Skip to content

feat: add terminal_features config for user-configurable terminal feature support#7383

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/support-non-breaking-changes
Draft

feat: add terminal_features config for user-configurable terminal feature support#7383
Copilot wants to merge 4 commits intomainfrom
copilot/support-non-breaking-changes

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 11, 2026

  • src/terminal/writer.go — invert SupportsFeature: Features now maps program → features
  • src/terminal/iterm.go — remove ITermFeatures type and gob.Register; rewrite RenderItermFeatures using SupportsFeature; add HasITermFeatures() guard
  • src/config/config.go — remove ITermFeatures field; update Fish PromptMark check to scan TerminalFeatures
  • src/prompt/primary.go — replace ITermFeatures != nil && isIterm() guard with HasITermFeatures()
  • src/terminal/writer_test.go — update TestSupportsFeature cases for inverted map shape; add iterm feature cases
  • themes/schema.json — remove iterm_features; update terminal_features description
  • website/docs/configuration/general.mdx — remove iterm_features row; update terminal_features row
  • Build and tests pass; CodeQL clean

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 3 commits March 11, 2026 19:25
Co-authored-by: JanDeDobbeleer <2492783+JanDeDobbeleer@users.noreply.github.com>
…ture support

Co-authored-by: JanDeDobbeleer <2492783+JanDeDobbeleer@users.noreply.github.com>
@heaths
Copy link
Copy Markdown
Contributor

heaths commented Mar 11, 2026

@JanDeDobbeleer so you're open to the terminal_features idea? I also wasn't sure whether it should be feature then terminal, or terminal and features. Either way, given the pace some terminals are moving (iTerm2 is always improving, and Ghostty is a fast up-and-comer - or like Windows Terminal did for quite a while not long ago) this is problem better than trying to keep OMP up to date.

…atures layout

Co-authored-by: JanDeDobbeleer <2492783+JanDeDobbeleer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants