Pin httpx dependency so spleeter follows redirects for model downloading#949
Merged
JeffreyCA merged 1 commit intoJeffreyCA:masterfrom Feb 2, 2024
Merged
Conversation
JeffreyCA
requested changes
Jan 28, 2024
Owner
JeffreyCA
left a comment
There was a problem hiding this comment.
Thanks for the fix and catching this! This was actually a regression in the recent release and the version of httpx being installed before was 0.19.0. Could we downgrade it instead in requirements.txt?
Contributor
Author
|
Sure, I'll try that. I assumed there was a reason for the version bump, so I did not investigate that avenue. But should there be safeguards in place to avoid a repetition of this problem? |
Owner
|
There's a |
323e898 to
6bae274
Compare
Contributor
Author
|
I verified that pinning |
Owner
|
Perfect, thanks again! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment,
spleetermodel downloads are failing, at least for me, because:spleetermodels when downloaded from github go through a redirection.spleeter-webspecifies ahttpxdependency of 0.26.0.httpxno longer follows redirects by default.spleeterfails to explicitly request following redirects.This issue has been called out in an unmerged
spleeterPR: deezer/spleeter#808 but that has not been merged for a long time.One possible solution might be to downgrade thehttpxdependency to < 0.20.0, but I don't know what other repercussions this could have. The other solution, which I've chosen here, is to fix thespleetercode with a patch applied at container build time.After discussion of alternatives with @JeffreyCA, this PR pins
httpxat 0.19.0