Add tests cleanup - #1
Closed
Patrick Woodworth (pwoodworth) wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like to see your tests from turn/ttorrent#46 get merged, but I imagine some of the delay might be from a mismatch in code style due in large part to (I assume editor) tab configuration. I've rolled back the addition of idea project files to reduce noise and reformatted things to match the upstream code style. You can see the extent of the non-idea, non-whitespace changes here pwoodworth@2aea9df?w=1 That link includes a ?w=1 at the end of the url in order to suppress display of whitespace changes.
I'm submitting to your branch so these changes will show up in your original PR request. If you'd prefer I could instead just submit my branch directly to turn/ttorrent in a new PR.