Add clearable search button to home search bar - #35
Open
Subhash-2005 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request converts the SearchCard widget into a StatefulWidget to introduce a clearable search field functionality. Key changes include adding a TextEditingController listener to track input and dynamically switching the suffix icon between a clear button and a filter icon. Review feedback suggests standardizing the README header, optimizing the text change listener to prevent unnecessary state updates, and adjusting the suffix icon implementation to maintain consistent UI styling when the field is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated [search_card.dart]
Converted SearchCard to a StatefulWidget
Added an interactive clear button that appears when search text is entered
Clears text when the button is tapped
Updated [README.md]
with a note describing the new feature