Skip to content

Add clearable search button to home search bar - #35

Open
Subhash-2005 wants to merge 3 commits into
JideGuru:masterfrom
Subhash-2005:feature/clearable-search
Open

Add clearable search button to home search bar#35
Subhash-2005 wants to merge 3 commits into
JideGuru:masterfrom
Subhash-2005:feature/clearable-search

Conversation

@Subhash-2005

Copy link
Copy Markdown

Updated [search_card.dart]
Converted SearchCard to a StatefulWidget
Added an interactive clear button that appears when search text is entered
Clears text when the button is tapped
Updated [README.md]
with a note describing the new feature

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request converts the SearchCard widget into a StatefulWidget to introduce a clearable search field functionality. Key changes include adding a TextEditingController listener to track input and dynamically switching the suffix icon between a clear button and a filter icon. Review feedback suggests standardizing the README header, optimizing the text change listener to prevent unnecessary state updates, and adjusting the suffix icon implementation to maintain consistent UI styling when the field is empty.

Comment thread README.md Outdated
Comment thread lib/widgets/search_card.dart
Comment thread lib/widgets/search_card.dart Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant