Validate HTML generator produces unique files#142
Open
erichoracek wants to merge 4 commits into
Open
Conversation
If you have a website with a `SectionID` case that has the same name as a page markdown file, right now whichever one ends up in the output is nondeterministic. This change adds a validation step to the `HTMLGenerator` to ensure uniqueness.
erichoracek
force-pushed
the
validate-duplicate-files
branch
from
17f7598 to
04f81bf
Compare
|
Interesting find. I just spent way too long figuring out why the top-level *.md files weren't updating. From what I've seen around the web...is the correct behavior to have a SectionID case match the .md file? |
codewithhart
pushed a commit
to codewithhart/Publish
that referenced
this pull request
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have a website with a
SectionIDcase that has the same name as a page markdown file, right now whichever one ends up in the output is nondeterministic. This change adds a validation step to theHTMLGeneratorto ensure uniqueness.