Changed website.url() to return path as is if it contains an absolute…#148
Open
Goosse wants to merge 1 commit into
Open
Changed website.url() to return path as is if it contains an absolute…#148Goosse wants to merge 1 commit into
Goosse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have absolute urls for my episode images hosted on digital ocean spaces. As it is, website.url() assumes path is a system path (absolute or relative), instead of containing an absolute url. This results in invalid urls when it prepends path with website.url.
I changed it to check for
http://andhttps://.