Feature: Page metadata#151
Open
jhonatn wants to merge 2 commits into
Open
Conversation
Through minimal changes. Includes updates to tests so they still work.
Contributor
Author
|
One test is failing, but it appears like the base commit in master was also failing, and reading the test doesn't give me much clue on how that method was supposed to throw an error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuses the implementation of WebsiteItemMetadata to add metadata to pages, but adds a default type for the PageMetadata associatedtype so it is not a hard requirement