README: Add dark mode variant of Logo.png#152
Open
TimOliver wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi John! I'm absolutely loving Publish! Thanks so much for this project! 🙏 Here's a small repo polish PR if you're interested! 😁
I use dark mode on GitHub, and I noticed the logo in the README doesn't really 'pop' that much on a dark background.
This PR adds a light mode variant (That matches the same shade of grey as GitHub's current body text), and then adjusts the README to dynamically display the appropriate variant on page load.
I also ran
pngcrushon the original logo and my dark mode variant and was able to shave 50% off the file size on both, so this change shouldn't increase the overall download size of the repo too.Hope that helps! Thanks for the consideration!
Before
After