Skip to content
This repository was archived by the owner on Apr 27, 2026. It is now read-only.

Orderbook Readability Issue #1330#1778

Open
18c83fd3-25ea-4ed9-8205-2abeff9b3883 wants to merge 1 commit intoJoinMarket-Org:masterfrom
18c83fd3-25ea-4ed9-8205-2abeff9b3883:orderbook-readability-issue-1330
Open

Orderbook Readability Issue #1330#1778
18c83fd3-25ea-4ed9-8205-2abeff9b3883 wants to merge 1 commit intoJoinMarket-Org:masterfrom
18c83fd3-25ea-4ed9-8205-2abeff9b3883:orderbook-readability-issue-1330

Conversation

@18c83fd3-25ea-4ed9-8205-2abeff9b3883
Copy link
Copy Markdown

Updated Orderbook UI for better readability:

  • The table is using monospace font, which makes the numbers align better
  • All values are displayed in satoshis (sats)
  • Numbers are formatted with commas (e.g., "100,000 sats" instead of "100000 sats")
  • The column headers consistently use "sats" as the unit

EXAMPLE:
image

@PulpCattel
Copy link
Copy Markdown
Member

Thanks for the PR.

A couple things from just a superficial look.

  • The fidelity bond value should not be in sats, but its own arbitrary unit. I think this is important or users might think that's the actual value of the locked UTXO, which is not. It's the result of the bond formula.
  • Is there a need a to add a sample orderbook? Not sure.
  • I don't think it's useful to repeat sats after every value, it seems better to just have it in the headers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants