This repository was archived by the owner on Apr 27, 2026. It is now read-only.
chore: migrate to ruff linting and formatting#1812
Open
roshii wants to merge 3 commits intoJoinMarket-Org:masterfrom
Open
chore: migrate to ruff linting and formatting#1812roshii wants to merge 3 commits intoJoinMarket-Org:masterfrom
roshii wants to merge 3 commits intoJoinMarket-Org:masterfrom
Conversation
3nprob
reviewed
Oct 26, 2025
Comment on lines
+50
to
+55
| if ( | ||
| re.compile(r"^[0-9]{1,8}(\.)?([0-9]{1,8})?(btc|sat)?$").match( | ||
| amount_str.lower() | ||
| ) | ||
| is None | ||
| ): |
There was a problem hiding this comment.
Would something like this still pass?
Suggested change
| if ( | |
| re.compile(r"^[0-9]{1,8}(\.)?([0-9]{1,8})?(btc|sat)?$").match( | |
| amount_str.lower() | |
| ) | |
| is None | |
| ): | |
| if re.compile( | |
| r"^[0-9]{1,8}(\.)?([0-9]{1,8})?(btc|sat)?$" | |
| ).match(amount_str.lower()) is None: |
or
Suggested change
| if ( | |
| re.compile(r"^[0-9]{1,8}(\.)?([0-9]{1,8})?(btc|sat)?$").match( | |
| amount_str.lower() | |
| ) | |
| is None | |
| ): | |
| if re.compile( | |
| r"^[0-9]{1,8}(\.)?([0-9]{1,8})?(btc|sat)?$" | |
| ).match( | |
| amount_str.lower() | |
| ) is None: |
Contributor
Author
There was a problem hiding this comment.
I assume ruff would reformat as is. Unless you can find the appropriate option, but it doesn't look like it according to docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to ruff linting and formatting. Formatting solely enforced to
./srcto limit review burden.I understand this PR is opinionated, opening it as a base for discussion. Hopefully everyone will agree that formatting is cumbersome and should be left to automation.