fix(heterovec): fix type mismatch in with_index generated comparison#12
Merged
SimonDanisch merged 1 commit intoJuliaGeometry:sd/multitype-vecfrom Mar 1, 2026
Conversation
SetKey.type_idx was changed from UInt8 to UInt32 for LLVM/SPIR-V compatibility, but the @generated with_index function still compared against UInt8 literals. Since Julia's === checks both value and type, UInt32(1) === UInt8(1) is always false, causing all branches to fall through to the default (first material). This made every object render with the same material. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetKey.type_idxwas changed fromUInt8toUInt32for LLVM/SPIR-V compatibility, but the@generatedwith_indexfunction still compared againstUInt8literals===checks both value and type,UInt32(1) === UInt8(1)is alwaysfalse, causing all branches to fall through to the default (first material)How these changes were tested
MatteMaterialcolors (red, green, purple) — all previously appeared gray, now render with correct colorsCreated with the help of Claude Code