Skip to content

fix for UnboundLocalError #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chidanandpujar merged 1 commit into from
May 18, 2026
Merged

fix for UnboundLocalError #824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions ansible_collections/juniper/device/plugins/connection/pyez.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,11 +503,16 @@ def get_rpc_resp(self, rpc, ignore_warning, format):
rpc_val = rpc_val.encode("utf-8")
parser = etree.XMLParser(ns_clean=True, recover=True, encoding="utf-8")
rpc_etree = etree.fromstring(rpc_val, parser=parser)
resp = self.dev.rpc(
rpc_etree,
normalize=bool(format == "xml"),
ignore_warning=ignore_warning,
)
try:
resp = self.dev.rpc(
rpc_etree,
normalize=bool(format == "xml"),
ignore_warning=ignore_warning,
)
except pyez_exception.RpcTimeoutError as ex:
raise AnsibleError("RpcTimeoutError: %s" % str(ex))
except (pyez_exception.RpcError, pyez_exception.ConnectError) as ex:
raise AnsibleError("RpcError: %s" % str(ex))
if format == "json":
return resp
return etree.tostring(resp)
Expand Down
16 changes: 12 additions & 4 deletions ansible_collections/juniper/device/plugins/modules/rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,10 +564,17 @@ def main():
format=format,
)
except Exception as ex:
if "RpcError" in (str(ex)):
raise junos_module.pyez_exception.RpcError
if "ConnectError" in (str(ex)):
raise junos_module.pyez_exception.ConnectError
junos_module.logger.debug(
'Unable to execute RPC "%s". Error: %s',
junos_module.etree.tostring(rpc, pretty_print=True),
str(ex),
)
result["msg"] = "Unable to execute the RPC: %s. Error: %s" % (
junos_module.etree.tostring(rpc, pretty_print=True),
str(ex),
)
results.append(result)
continue
result["msg"] = "The RPC executed successfully."
junos_module.logger.debug(
'RPC "%s" executed successfully.',
Expand All @@ -576,6 +583,7 @@ def main():
except (
junos_module.pyez_exception.ConnectError,
junos_module.pyez_exception.RpcError,
junos_module.pyez_exception.RpcTimeoutError,
) as ex:
junos_module.logger.debug(
'Unable to execute RPC "%s". Error: %s',
Expand Down
Loading