Cleanup requirements.txt and remove Python 2 support for unit tests#832
Open
ChihweiLHBird wants to merge 3 commits into
Open
Cleanup requirements.txt and remove Python 2 support for unit tests#832ChihweiLHBird wants to merge 3 commits into
ChihweiLHBird wants to merge 3 commits into
Conversation
The tests/unit/requirements.txt contained dependencies for many other collections (boto3, f5-sdk, linode-python, etc.) and was not used by any junipernetworks.junos unit test. The file is a stale artifact from a shared Ansible network collection requirements template. Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
ChihweiLHBird
force-pushed
the
zhiwei/clean-up-unit-test-requirements
branch
from
fd6776b to
a3b1ea2
Compare
ChihweiLHBird
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requirements.txtis no longer relevant (discovered this while doing a Internet scan looking for usage of retired Linode API v3,linode-pythonpackage), and Python 2 has been EOL for many years.Similar to what has been done in other collections:
ansible-collections/cisco.ios@be921c6
ansible-collections/cisco.ios@9e752fa