Skip to content

allow_agent param support#1388

Merged
dineshbaburam91 merged 1 commit into
Juniper:masterfrom
chidanandpujar:agentfix1
Jan 7, 2026
Merged

allow_agent param support#1388
dineshbaburam91 merged 1 commit into
Juniper:masterfrom
chidanandpujar:agentfix1

Conversation

@chidanandpujar

Copy link
Copy Markdown
Collaborator

Support for allow_agent parameter

#1385
#1285
#1353

@chidanandpujar

Copy link
Copy Markdown
Collaborator Author

HI @dineshbaburam91,
UT and FT looks to be working fine.

test_arp_table (tests.functional.test_table_present.test_table.test_arp_table) ... ['56:04:1b:00:30:a7', '00:01:00:02:00:03', '54:04:0a:35:65:32', '54:04:0a:35:65:52', '54:04:0a:35:65:b6', '54:04:0a:35:66:ed', '54:04:0a:35:67:37', '54:04:0a:35:6a:6c', '54:04:0a:35:6b:00', '54:04:0a:35:6b:c6', '54:04:0a:35:6e:20', '54:04:0a:35:6e:4c', '84:b5:9c:cd:24:40', '56:04:1b:00:30:a7', '56:04:1b:00:30:a7', '56:04:1b:00:30:a3']
ok
test_arp_table_to_json (tests.functional.test_table_present.test_table.test_arp_table_to_json) ... ok
test_table_get_value (tests.functional.test_table_present.test_table.test_table_get_value) ... ok
test_utils_fs_cat (tests.functional.test_utils_file_system.TestUtilsFS.test_utils_fs_cat) ... ok
test_utils_fs_checksum (tests.functional.test_utils_file_system.TestUtilsFS.test_utils_fs_checksum) ... ok
test_utils_fs_cp (tests.functional.test_utils_file_system.TestUtilsFS.test_utils_fs_cp) ... ok
test_utils_fs_ls (tests.functional.test_utils_file_system.TestUtilsFS.test_utils_fs_ls) ... ok
test_utils_fs_mkdir (tests.functional.test_utils_file_system.TestUtilsFS.test_utils_fs_mkdir) ... ok
test_utils_fs_mv (tests.functional.test_utils_file_system.TestUtilsFS.test_utils_fs_mv) ... ok
test_utils_fs_pwd (tests.functional.test_utils_file_system.TestUtilsFS.test_utils_fs_pwd) ... ok
test_utils_fs_rm (tests.functional.test_utils_file_system.TestUtilsFS.test_utils_fs_rm) ... ok
test_utils_fs_rmdir (tests.functional.test_utils_file_system.TestUtilsFS.test_utils_fs_rmdir) ... ok
test_utils_fs_stat (tests.functional.test_utils_file_system.TestUtilsFS.test_utils_fs_stat) ... ok
test_utils_fs_storageUsage (tests.functional.test_utils_file_system.TestUtilsFS.test_utils_fs_storageUsage) ... ok
test_utils_fs_symlink (tests.functional.test_utils_file_system.TestUtilsFS.test_utils_fs_symlink) ... ok
test_utils_fs_tgz (tests.functional.test_utils_file_system.TestUtilsFS.test_utils_fs_tgz) ... ok
test_device_facts (tests.functional.test_core.TestCore.test_device_facts) ... ok
test_device_get_timeout (tests.functional.test_core.TestCore.test_device_get_timeout) ... ok
test_device_open (tests.functional.test_core.TestCore.test_device_open) ... ok
test_device_rpc (tests.functional.test_core.TestCore.test_device_rpc) ... ok
test_device_rpc_format_text (tests.functional.test_core.TestCore.test_device_rpc_format_text) ... ok
test_device_rpc_normalize_true (tests.functional.test_core.TestCore.test_device_rpc_normalize_true) ... ok
test_device_rpc_timeout (tests.functional.test_core.TestCore.test_device_rpc_timeout) ... ok
test_device_set_timeout (tests.functional.test_core.TestCore.test_device_set_timeout) ... ok
test_load_config (tests.functional.test_core.TestCore.test_load_config) ... ok
test_load_config_jinja2 (tests.functional.test_config.TestCore.test_load_config_jinja2) ... ok
test_load_config_jinja2_template (tests.functional.test_config.TestCore.test_load_config_jinja2_template) ... ok
test_load_config_json (tests.functional.test_config.TestCore.test_load_config_json) ... ok
test_load_config_set (tests.functional.test_config.TestCore.test_load_config_set) ... ok
test_load_config_text (tests.functional.test_config.TestCore.test_load_config_text) ... ok
test_load_config_xml (tests.functional.test_config.TestCore.test_load_config_xml) ... ok
test_scp_put (tests.functional.test_file_scp.test.test_scp_put) ... 10.53.103.61: b'scp_file.txt': 1 / 1 (100%)
ok
test_scp_put_file_get (tests.functional.test_file_scp.test.test_scp_put_file_get) ... ok
test_table_json (tests.functional.test_table.TestTable.test_table_json) ... ok
test_table_union (tests.functional.test_table.TestTable.test_table_union) ... ok
test_config_exception (tests.functional.test_exception.TestUtilFs.test_config_exception) ... ok
test_device_rpc_timeout (tests.functional.test_exception.TestUtilFs.test_device_rpc_timeout) ... ok
test_exception (tests.functional.test_exception.TestUtilFs.test_exception) ... ok
test_exception_commitError (tests.functional.test_exception.TestUtilFs.test_exception_commitError) ... ok
test_exception_commitError_commitCheck (tests.functional.test_exception.TestUtilFs.test_exception_commitError_commitCheck) ... ok
test_exception_severity (tests.functional.test_exception.TestUtilFs.test_exception_severity) ... ok
test_FS_checksum (tests.functional.test_exception.TestUtilFs.test_FS_checksum) ... ok
test_load_exception (tests.functional.test_exception.TestUtilFs.test_load_exception) ... ok
test_lock_exception (tests.functional.test_exception.TestUtilFs.test_lock_exception) ... ok
test_rescue_action (tests.functional.test_exception.TestUtilFs.test_rescue_action) ... ok
test_rollback_id (tests.functional.test_exception.TestUtilFs.test_rollback_id) ... ok
test_rpc_exception (tests.functional.test_exception.TestUtilFs.test_rpc_exception) ... ok
test_rpc_exist (tests.functional.test_exception.TestUtilFs.test_rpc_exist) ... ok
test_rpc_load_extension (tests.functional.test_exception.TestUtilFs.test_rpc_load_extension) ... ok
test_rpc_no_format (tests.functional.test_exception.TestUtilFs.test_rpc_no_format) ... ok
test_rpc_set_override (tests.functional.test_exception.TestUtilFs.test_rpc_set_override) ... ok
test_unlock_exception (tests.functional.test_exception.TestUtilFs.test_unlock_exception) ... ok
test_device_open_key_pass (tests.functional.test_device_ssh.TestDeviceSsh.test_device_open_key_pass) ... ok
test_device_rpc (tests.functional.test_rpc.TestCore.test_device_rpc) ... ok
test_device_rpc_format_text (tests.functional.test_rpc.TestCore.test_device_rpc_format_text) ... ok
test_device_rpc_timeout (tests.functional.test_rpc.TestCore.test_device_rpc_timeout) ... ok
test_display_xml_rpc (tests.functional.test_rpc.TestCore.test_display_xml_rpc) ... ok
test_getConfig (tests.functional.test_rpc.TestCore.test_getConfig) ... ok
test_interface_terse_text (tests.functional.test_rpc.TestCore.test_interface_terse_text) ... ok
test_route_information (tests.functional.test_rpc.TestCore.test_route_information) ... ok
test_rpc_get_interface_information_mtun (tests.functional.test_rpc.TestCore.test_rpc_get_interface_information_mtun) ... ok
test_shell_run (tests.functional.test_shell.test.test_shell_run) ... ok

----------------------------------------------------------------------
Ran 62 tests in 173.559s

OK

@dineshbaburam91 dineshbaburam91 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dineshbaburam91 dineshbaburam91 merged commit e23fe2d into Juniper:master Jan 7, 2026
7 checks passed
@vincentbernat

Copy link
Copy Markdown
Contributor

In almost 10 years, nobody demonstrated a need to disable the agent. This is a setting not available in the OpenSSH client. While the ability to make this configurable is better than nothing, this setting may not be exposed in dependent libraries or applications, making secure usage of PyEZ a pain (password-protected SSH keys or SSH keys on Yubikey for example). #1285 is a simpler fix.

Also see #648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants