Skip to content

Gathered facts of satellite device#1417

Merged
chidanandpujar merged 3 commits into
Juniper:masterfrom
dineshbaburam91:test
Jun 16, 2026
Merged

Gathered facts of satellite device#1417
chidanandpujar merged 3 commits into
Juniper:masterfrom
dineshbaburam91:test

Conversation

@dineshbaburam91

@dineshbaburam91 dineshbaburam91 commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Gathered facts about the satellite device

Description

Gathered facts about the satellite device

Closes #

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Feature / Enhancement (non-breaking change that adds functionality)
  • Task / Chore (refactor, dependency update, CI, docs, etc.)
  • Breaking change (fix or feature that would cause existing functionality to change)

Changes Made

  • get_jnu_satellites_information.py — New facts module that collects satellite device information via get-jnu-satellites-information RPC. Provides jnu_satellite (bool) and satellites_info (dict with per-satellite facts: alive, hostname, model, version, serialnumber, 2RE, RE0, RE1, re_info, re_master, vc_capable, vc_mode, vc_master, etc.)

  • satellites.py — Old-style facts module (ofacts pattern) for satellite facts using the same logic

  • test_get_jnu_satellites_information.py — 9 unit tests for the satellite facts module


Checklist

Code Quality

  • Code follows the project's style guidelines
  • ruff format --check . passes with no formatting issues
  • pylint reports no new errors or warnings (run against changed .py files)
ruff format --check .
pylint <changed_files>

Unit Tests

  • New or updated unit tests have been added under tests/unit/
  • All unit tests pass locally
nose2 -vvv tests.unit --with-coverage --coverage-report xml
  • Code coverage has not decreased (check coverage.xml)

Functional Tests

  • Functional tests in tests/functional/ have been reviewed for impact
  • Any affected functional tests pass (requires a live Junos device or vMX)
nose2 -vvv tests.functional

Documentation

  • Docstrings updated for any new/changed public methods or classes
  • Sphinx docs build cleanly (if docs were changed)
sphinx-build -b html docs docs/_build/html -W

General

  • RELEASE-NOTES.md updated (if applicable)
  • No hardcoded credentials, IPs, or sensitive data introduced
  • Dependencies in requirements.txt updated (if new packages were added)

Testing Matrix

Python OS Passed?
3.x Junos [Passed]

Additional Notes

@chidanandpujar

Copy link
Copy Markdown
Collaborator

Hi @dineshbaburam91
please validate UT and FT tests with your changes

Thanks
Chidanand

@chidanandpujar chidanandpujar merged commit 4e3dfd6 into Juniper:master Jun 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants