Skip to content

Updated the Sw install output messages in the progress callback#1418

Merged
chidanandpujar merged 1 commit into
Juniper:masterfrom
dineshbaburam91:test
Jun 16, 2026
Merged

Updated the Sw install output messages in the progress callback#1418
chidanandpujar merged 1 commit into
Juniper:masterfrom
dineshbaburam91:test

Conversation

@dineshbaburam91

@dineshbaburam91 dineshbaburam91 commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Description

Updated the Sw install output messages in the progress callback

Closes #

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Feature / Enhancement (non-breaking change that adds functionality)
  • Task / Chore (refactor, dependency update, CI, docs, etc.)
  • Breaking change (fix or feature that would cause existing functionality to change)

Changes Made


Checklist

Code Quality

  • Code follows the project's style guidelines
  • ruff format --check . passes with no formatting issues
  • pylint reports no new errors or warnings (run against changed .py files)
ruff format --check .
pylint <changed_files>

Unit Tests

  • New or updated unit tests have been added under tests/unit/
  • All unit tests pass locally
nose2 -vvv tests.unit --with-coverage --coverage-report xml
  • Code coverage has not decreased (check coverage.xml)

Functional Tests

  • Functional tests in tests/functional/ have been reviewed for impact
  • Any affected functional tests pass (requires a live Junos device or vMX)
nose2 -vvv tests.functional

Documentation

  • Docstrings updated for any new/changed public methods or classes
  • Sphinx docs build cleanly (if docs were changed)
sphinx-build -b html docs docs/_build/html -W

General

  • RELEASE-NOTES.md updated (if applicable)
  • No hardcoded credentials, IPs, or sensitive data introduced
  • Dependencies in requirements.txt updated (if new packages were added)

Testing Matrix

Python OS Passed?
3.x [ ]

Additional Notes

@chidanandpujar chidanandpujar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add UT to cover the nested XML path, response on multi RE and VC setup. please check NSSU/ISSU/single RE/multi-RE upgrade scenarios

@chidanandpujar chidanandpujar merged commit 411efc5 into Juniper:master Jun 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants