Contributors are welcome!

[uriklar]

Hi everyone,
We'd love to get your code contributions! We have a slack channel that is currently on an invite basis. Leave a note here if you want to join.

There are some components that need to be revised from their old (react-google-maps) implementation, to our new implementation. For an examples of such a conversion, see this commit

Here are the components that still need to be implemented

• StreetViewPanorama
• StreetViewService
• AutoComplete
• StandaloneSearchBox
• InfoBox
• ImageMapType
• Data
• MarkerClusterer

Other open tasks:

• Docs! You can see example mdx files in the docs folder. We want to achieve coverage for all components in the docs
• Examples Gatsby.js
• Examplex Create React App
• Code cleanup (remove unused code leftover from react-google-maps)
• Typescript support
• Jest tests,
• End-to-end tests
• Write a migration guide from react-google-maps to react-google-maps-api
• Publish docs as github pages (published on netlify)

[shafqatalix]

Hi @uriklar , I am working on another fork of react-google-maps, but since you guys already started this one, i would like to contribute instead of perusing my own fork. I am working on project which uses react-google-maps, and i faced some issues for which i had to override some behaviors in some of the components.

• OverlayView
• Workaound (fix) for Google Maps Memory Leak mentioned in here
  I have Higher-Order-Component to get around this issues.
• Few more addOns to help customizing maps UI.

Please let me know If that is something you would like to incorporate into this fork? Then i can start working on preparing PR. Plus one more thing this lib doesn't build on windows machine, and i have to add few things to package.json make is work.

[uriklar]

Hi @xalisys, we'd be happy to add you code. I saw your fork, but didn't see the commits you mentioned. Can you send me a link?

And a PR to fix the windows build would be greatly appreciated!

[shafqatalix]

@uriklar thanks for quick response, the code i mentioned is in my project where i override the react-google-maps, components. I'll create separate PRs for things aforementioned.

thanks.

[gregoryfm]

Hi @uriklar
I'm willing to help.
Can you add me in the slack group to let me know where to start?

[uriklar]

Hi @gregoryfm! Send me the email of your slack account and i'll send you an invite. (You can also mail me at uriklar@gmail.com if you prefer)

[gregoryfm]

I sent you an email

[danielkcz]

As I already mentioned somewhere else ... I would like to contribute, however seeing this project is almost dead already, I don't feel like it's worth the time. Did everyone get so busy suddenly to let this die?

[uriklar]

Hi @FredyC, Why do you say it's dead?
I think the lib has reached an MVP state and from now on it will grow to wherever people will have the need and the time to make it grow.

As Alexey mentioned in several places, we use this lib for our personal and company's projects, so our work on it is focused on those needs. But we will gladly help anyone who wants to contribute and will surely put in some more work in when we have the time for it.

[danielkcz]

I totally understand it's not like the main project you want to invest too much time into. In that case, it might been better to just keep it private instead of saying everywhere that this is a replacement lib. How it can be when it's lacking features that react-google-maps have?

Do you even adhere to semver? With your "hobby" approach I feel like the stability could be rather volatile. There are no tests which I would say is kinda a must for a library. Otherwise, it's just a code that was mangled together to make some basic scenarios working (with fingers crossed). Documentation is rather sparse and it's hard to tell what's actually working and what isn't.

I do appreciate your valiant effort for sure, but at this point, I feel like I would just fork react-google-maps, cherry-pick commits from existing PRs and it would be much safer and easier for existing production apps.

[uriklar]

First of all, for the best of my knowledge react-google-maps doesn't have any tests either.
This is a project at the beginning of it's path. We made it public so we can start gathering react-google-map users and show them there's a home for their map needs if they wish to come and help build it.

I know that some components are missing, but, did you look at the code? It's so easy to just pick a component up and implement it! For documentation we use docz which makes adding docs even easier. I agree with you this project deserves more work then it gets..

If react-google-maps works for you, I don't see any reason to migrate. For me, the main use case for migrating from would have to be Async React readiness (which @react-google-maps/api is), also reduced bundle size is a nice touch.

[danielkcz]

First of all, for the best of my knowledge react-google-maps doesn't have any tests either.

Fair enough, there are a few basic tests, but probably not that useful.

I know that some components are missing, but, did you look at the code?

I did not. Honestly, seeing JS code base just gives me shivers as it means that touching anything can break stuff fairly easily (especially with no tests). Unless the decision for TypeScript happens, I don't think I will be able to contribute.

If react-google-maps works for you, I don't see any reason to migrate. For me, the main use case for migrating from would have to be Async React readiness (which @react-google-maps/api is), also reduced bundle size is a nice touch.

It works, but there are some quicks for sure that could be solved here better. For starters we have fully embraced React Hooks, so seeing class-based context is just bad :)

[uriklar]

We haven't used hooks in this project as they haven't been released yet. Once they're released this whole lib might as well be shrunk into a single hook :-)
You can see a (non-working) POC here: https://github.com/JustFly1984/react-google-maps-api/blob/master/packages/react-google-maps-api/src/utils/use-map-component.js

If you feel like making a PR to kick off the Typescript migration effort I will gladly join in on that branch!

[JustFly1984]

@FredyC We have done refactor to typescript, if you have time can you please review?