feat(code-review): add alerts#3136
Draft
alex-alecu wants to merge 1 commit intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Code review jobs can get stuck or fail a lot without one clear signal. This adds a simple alert so the team can see when the code review system needs attention.
What changed
A new scheduled check now looks at code review health every five minutes. It catches high failure rates, stuck reviews, missing completions, and one error type becoming too common. When a problem is found, it checks a shared cooldown before sending a Slack alert, so the team does not get repeated messages for the same problem. The cooldown state is stored in the existing o11y service.
How to test
pnpm --filter cloudflare-o11y test -- code-review-dedup.pnpm --filter web typecheck.pnpm --filter web lint.