Skip to content

chore(gastown): remove manual request logging middleware #3158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrf0110 merged 3 commits into from
May 10, 2026
Merged

chore(gastown): remove manual request logging middleware #3158

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
921d621
chore(gastown): remove manual request logging middleware
May 9, 2026
2f1cac3
fix(gastown): unblock /agents/start during boot hydration; preserve m…
jrf0110 May 9, 2026
5812745
feat(gastown): per-route logger tagging via Hono params (review on #3…
May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions services/gastown/src/gastown.worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ import { townAuthMiddleware } from './middleware/town-auth.middleware';
import { orgAuthMiddleware } from './middleware/org-auth.middleware';
import { adminAuditMiddleware } from './middleware/admin-audit.middleware';
import { timingMiddleware, instrumented } from './middleware/analytics.middleware';
import { logger } from './util/log.util';
import { useWorkersLogger } from 'workers-tagged-logger';
import type { MiddlewareHandler } from 'hono';
import { handleGetTownConfig, handleUpdateTownConfig } from './handlers/town-config.handler';
Expand Down Expand Up @@ -173,35 +172,6 @@ app.use('*', timingMiddleware);
// Cast needed: workers-tagged-logger@1.0.0 was built against an older Hono.
app.use('*', useWorkersLogger('gastown-worker') as unknown as MiddlewareHandler);

// ── Request logging ─────────────────────────────────────────────────────
// Extract IDs from the URL path directly — c.req.param() only works
// after Hono has matched a route, which hasn't happened yet in a
// wildcard middleware.
// Matches /orgs/:orgId, /towns/:townId, /rigs/:rigId, /agents/:agentId
// in any combination that appears in our route patterns.
const RE_ORG = /\/orgs\/(?<orgId>[^/]+)/;
const RE_TOWN = /\/towns\/(?<townId>[^/]+)/;
const RE_RIG = /\/rigs\/(?<rigId>[^/]+)/;
const RE_AGENT = /\/agents\/(?<agentId>[^/]+)/;

app.use('*', async (c, next) => {
const method = c.req.method;
const path = c.req.path;
// Tag with route params immediately so all downstream logs (auth,
// handlers, DO calls) inherit them. Auth-derived tags (userId, orgId)
// are set by kiloAuthMiddleware and orgAuthMiddleware when they run.
logger.setTags({
orgId: RE_ORG.exec(path)?.groups?.orgId,
townId: RE_TOWN.exec(path)?.groups?.townId,
rigId: RE_RIG.exec(path)?.groups?.rigId,
agentId: RE_AGENT.exec(path)?.groups?.agentId,
});
Comment on lines -193 to -198
Copy link
Copy Markdown
Contributor Author

@jrf0110 jrf0110 May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd still be nice to set tags on requests, but maybe we can do it in a way more structured way like:

app.use('/api/towns/:townId', async (c, next) => {
  logger.setTags({ townId: c.req.param('townId' })
  await next()
})

logger.info(`--> ${method} ${path}`);
await next();
const elapsed = Math.round(performance.now() - (c.get('requestStartTime') ?? 0));
logger.info(`<-- ${method} ${path} ${c.res.status}`, { durationMs: elapsed });
});

// ── CORS ────────────────────────────────────────────────────────────────
// Allow browser requests from the main Kilo app. In development, allow
// localhost origins for the Next.js dev server.
Expand Down