refactor(ui): move Kilo-only i18n keys to kilo-ui#10029
Open
kilo-code-bot[bot] wants to merge 2 commits intomainfrom
Open
refactor(ui): move Kilo-only i18n keys to kilo-ui#10029kilo-code-bot[bot] wants to merge 2 commits intomainfrom
kilo-code-bot[bot] wants to merge 2 commits intomainfrom
Conversation
Moves Kilo-specific translation keys (delegatingWaitingPermission/Question, messagePart.mcp.input/output, message.revertMessage override) out of packages/ui/src/i18n/ and into kilo-ui's locale files, so the upstream-shared locales become byte-identical to upstream and don't conflict on every merge. Kept in packages/ui: - nl.ts and uk.ts (Kilo-added languages, no upstream conflict) - gap-fill translations of upstream-defined keys (sessionReview.title.git/branch, sessionTurn.diffs.*) — those are translations of upstream's own keys Also dropped the dead 'ui.message.revert' key (no code references it).
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by gpt-5.5-2026-04-23 · 456,910 tokens |
…on check The annotation check compares against the last merged upstream tag (v1.14.33), where Kilo had this line overridden to 'Revert to here'. Reverting it cleanly to upstream's value triggers the check because it sees a Kilo-specific change. The value now matches upstream so future merges resolve cleanly via zdiff3 (only the trailing comment will conflict, which is trivial).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves Kilo-specific translation keys out of
packages/ui/src/i18n/and intopackages/kilo-ui/src/i18n/, so the upstream-shared locale files become byte-identical to upstream and stop conflicting on every upstream merge.What moved to kilo-ui
ui.sessionTurn.status.delegatingWaitingPermission/Questionui.messagePart.mcp.input/outputui.message.revertMessageoverride ("Revert to here" instead of upstream's "Revert message")The dead
ui.message.revertkey was dropped (no code references it).What stayed in packages/ui
nl.tsanduk.ts(Kilo-added languages — kept here for consistency, they don't conflict with upstream)ui.sessionReview.title.git/branch,ui.sessionTurn.diffs.*) — these are translations of upstream's own keys and complete what upstream left in English.Verification
bun run typecheck— all 10 packages passbun test ./tests/unit/i18n-keys.test.ts— 7/7 pass (after pointing the test imports at@kilocode/kilo-ui/i18n/*instead of the underlyingpackages/uipaths, since that's the actual import path the webview uses)bun test ./tests/unit/— 2195/2195 passscript/upstream/reset-to-upstream.tsconfirms remaining diffs in shared locale files are only the gap-fill translations + mermaidkilocode_changeblock inen.ts