Skip to content

Bump acorn from 5.7.3 to 5.7.4#2

Open
dependabot[bot] wants to merge 4 commits into
developfrom
dependabot/npm_and_yarn/acorn-5.7.4
Open

Bump acorn from 5.7.3 to 5.7.4#2
dependabot[bot] wants to merge 4 commits into
developfrom
dependabot/npm_and_yarn/acorn-5.7.4

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Mar 15, 2020

Copy link
Copy Markdown

Bumps acorn from 5.7.3 to 5.7.4.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Mar 15, 2020
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/acorn-5.7.4 branch from 0c4c093 to ba21457 Compare March 31, 2020 15:45
Configure enzyme setup in setupTests.js file.
Add some DOM testing with Enzyme for Task component.

Tips:
- Enzyme is a React components testing library. It can be coupled with Jest as it provides more utilities to test your React components. It can provide more specificity than a simple rendering test.
- "shallow" is one of the methods that use Enzyme to render a component. It is used to test a component as a single unit, not handling the potential children related.
- Sometimes you might want to choose the important features that are testing-worth instead of test every single part of a component.
- Enzyme needs a small configuration provided in setupTest.js file.
- When testing a component's child node, you might want to be very specific by using a custom attribute to identify the node you are looking for.
- Here is a cheatsheet that can be useful using Enzyme:
https://devhints.io/enzyme
… and REPLACE_TASK correctly.

Create a reducers/tasks folder that will contain both the reducer and the test related.

Tips:
- Here we have created a "state" re-assignable variable inside our new describe block. It allow us to keep the same state across those reducer tests. In this case it makes sens to keep our previous state and make it evolve instead of keep initializing it before each unit test.
- ".spec" file suffix is also part of the test files naming convention.
… the store.

Add test to assert that our action creator "fetchTodos" is executed correctly.
Add getTestStore helper that provide an instance of a similar store used in the app.
Add "axios-mock-adapter" package to provide a mock test for our requests.
Add a condition to use redux devtools middleware only when running on a browser with the extension installed.

Tips:
- When you are testing an asynchronous action, you might want to mock the API call instead of using some data that can be directly related to the app state.
- Here we installed axios-mock-adapter to mock our API calls, it is a specific mock library for request made with axios. To use it, simply declare an expected response on a specific API URI. Next time you will make a call to this URI you will get the specified response.
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@5.7.3...5.7.4)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/acorn-5.7.4 branch from ba21457 to eb77298 Compare April 7, 2020 13:16
@KingPepito KingPepito force-pushed the develop branch 2 times, most recently from 934c86a to b08710f Compare April 9, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant