Add interactive text-query annotation button#1708
Open
mattdawkins wants to merge 10 commits into
Open
Conversation
Brings in the SAM2/SAM3-based interactive segmentation feature, the SAM3 text-query workflow, and the desktop interactive stereo mode. Web-girder paths are intentionally untouched for now — web support will come in a follow-up. - New segmentation point-click recipe + EditorMenu wiring; SAM2/SAM3 models loaded via VIAME install configs. - Desktop backend: viame_segmentation_service-backed IPC handlers and matching frontend API for segmentationInitialize/Predict/SetImage/ ClearImage/Shutdown/IsReady, textQuery/refineDetections/ runTextQueryPipeline, and stereoEnable/Disable/SetFrame/GetStatus/ TransferLine/TransferPoints/SetCalibration/IsEnabled, plus disparity ready/error event hooks. - EditAnnotationLayer: track shift-key state and right-click for Point mode, propagate background flag for negative SAM points. - Sidebar / ViewerLoader / Viewer: stereo annotation mode UI, error dialog when seg or text-query model fails to load, dot-only-on-source -frame fix. - useModeManager / EditAnnotationLayer / recipes: keep existing geometry type when current editing mode already matches; right-click in Point creation finalises and deselects.
A track-frame's polygon now expands to a list of polygons each with their own keys, and each polygon supports holes. - Server CSV (de)serializer: emit polygon-key column per polygon, support holes in the geoJSON FeatureCollection; auto_key path to append a new polygon to an existing track frame. - Client recipes / useModeManager: handleAddHole / handleAddPolygon / handleCancelCreation; PolygonLayer emits polygon-clicked. - Hole drawing reuses the polygon edit pipeline (left-click places a hole vertex without exiting creation mode). - Test fixtures cover multi-polygon and polygons-with-holes round-trip.
(cherry picked from commit c2f3cd0)
(cherry picked from commit 3db1995)
(cherry picked from commit b7d4fa3)
(cherry picked from commit f5d015a)
…tton) Strip the SAM3 text-query button, dialog, API, and IPC handlers from the interactive editor, keeping segmentation and stereo intact. The full text-query feature lives on the follow-up branch dev/text-query-annot-button.
Strip the no-transcode NativeVideoAnnotator path that should not be on the segmentation/stereo branch: removes the residual Viewer.vue async-component, nativeVideoPath plumbing, and template branch, plus the stale settings field.
mattdawkins
force-pushed
the
dev/add-interactive-seg-and-stereo
branch
from
7858f2f to
20303f0
Compare
mattdawkins
force-pushed
the
dev/text-query-annot-button
branch
from
7d03471 to
37bc67d
Compare
The rebase onto main dropped the opening <template> tag, so vite parsed the root <div> as a custom block and the electron build failed. Restore it.
SAM3 text-query button, dialog, API, and IPC handlers on top of the interactive segmentation + stereo branch.
mattdawkins
force-pushed
the
dev/text-query-annot-button
branch
from
37bc67d to
fc8e213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1582. Adds the SAM3 interactive text-query annotation button on top of the interactive segmentation + stereo branch.
Changes
textQuery/refineDetections/runTextQueryPipelinefrontend API + IPC handlers.text-query-init/text-query/text-query-all-frames, service-ready forwarding).Notes
dev/add-interactive-seg-and-stereo; review/merge Add interactive segmentation, stereo, and multi-polygon support #1582 first.