Skip to content

feat: allow symfony 8#536

Merged
qroques merged 3 commits intoKnpLabs:masterfrom
Chris53897:feature/symfony-8-new
Feb 13, 2026
Merged

feat: allow symfony 8#536
qroques merged 3 commits intoKnpLabs:masterfrom
Chris53897:feature/symfony-8-new

Conversation

@Chris53897
Copy link
Copy Markdown
Contributor

ci blocked by #535

@Chris53897
Copy link
Copy Markdown
Contributor Author

I have added a testrun for PHP 8.5 with Symfony 8.
https://github.com/KnpLabs/snappy/actions/runs/20163501882/job/57881258237?pr=536

@Chris53897
Copy link
Copy Markdown
Contributor Author

I have integrated the important change from #535 to get the ci green.
@AntoineGonzalez Could you please have a look ?

@tacman
Copy link
Copy Markdown

tacman commented Dec 27, 2025

Thanks to all who have contributed to this and making it Symfony 8 / PHP 8.5 compatible.

@trsteel88
Copy link
Copy Markdown
Contributor

Is there something holding this up so it can be merged?

@tacman
Copy link
Copy Markdown

tacman commented Jan 27, 2026

It's just symfony/process, right? That's had a rock-solid API for ages. At this point, I think it'd be better to accept the PR and see if it breaks than to wait. tests are passing, right?

@Chris53897
Copy link
Copy Markdown
Contributor Author

@trsteel88
Copy link
Copy Markdown
Contributor

Any update on this?

@tacman
Copy link
Copy Markdown

tacman commented Feb 4, 2026

I saw Snappy mentioned in this article

https://medium.com/@laurentmn/build-better-symfony-apps-with-these-9-underrated-bundle-9bc40eb0de65

It'd be great if it ran with the latest version of Symfony!

@trsteel88
Copy link
Copy Markdown
Contributor

@simonberton are you able to review and approve this?

@jwpage
Copy link
Copy Markdown

jwpage commented Feb 7, 2026

Looks like it has been approved, we just need someone to hit that "merge" button 😎

@romainnorberg
Copy link
Copy Markdown

+1 🙏 Thanks

@davidm-glitch
Copy link
Copy Markdown

+1 🙏

@qroques qroques merged commit af73003 into KnpLabs:master Feb 13, 2026
20 checks passed
@tacman
Copy link
Copy Markdown

tacman commented Feb 13, 2026

Wahoo! Thanks! I know it was only 8 minutes ago, can you publish a new release?

@Chris53897 Chris53897 deleted the feature/symfony-8-new branch February 13, 2026 15:35
@tacman
Copy link
Copy Markdown

tacman commented Feb 14, 2026

I see 1.6 is out, thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.