Added GroupBy transformation KDocs - #1936
Open
AndreiKingsley wants to merge 2 commits into
Open
Conversation
Collaborator
|
please update the description to include the |
Jolanrensen
requested changes
Jul 27, 2026
| * This is an entity formed by calling any (combination) of the functions | ||
| * in the DSL that is or can be resolved into a single column. | ||
| * | ||
| * Column Selection DSL allows using [Extension Properties][AccessApis.ExtensionPropertiesApi] |
Collaborator
There was a problem hiding this comment.
*The Columns Selection DSL
| private typealias SortDslSnippet = Nothing | ||
|
|
||
| /** | ||
| * A specialized [ColumnsSelectionDsl] for selecting columns to sort rows by |
Collaborator
There was a problem hiding this comment.
use {@include [ColumnsSelectionDslLink]}
| * | ||
| * @include [SortDslSnippet] | ||
| * | ||
| * See {@include [CSDslLink]}. |
Collaborator
There was a problem hiding this comment.
ah it seems we have two of these links
Collaborator
There was a problem hiding this comment.
{@include [ColumnsSelectionDslLink]} and {@include [CSDslLink]} do the same thing
| * gb.sortByGroup { group -> group.rowsCount() * group.quantity.max() } | ||
| * ``` | ||
| * | ||
| * @param [nullsLast] Whether `null` values should be placed after non-null values. |
Collaborator
There was a problem hiding this comment.
again "after"? better: "considered greater than non-null values"
Collaborator
There was a problem hiding this comment.
actually... if "last" always means "last", like I commented before, it's probably fine. I'm just a bit confused about ascending/descending + nullsFirst/nullsLast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1526 + KDocs for
DataFrame.sort..()methods + renamed.desc()to.reversed()