Draft
Remove TraversePropertiesDsl from top-level toDataFrame {} operation#2004
Conversation
- Remove TraversePropertiesDsl as supertype of CreateDataFrameDsl<T>
- Remove TraversePropertiesDsl delegation from CreateDataFrameDslImpl
- Add deprecated exclude/preserve methods to CreateDataFrameDsl with deprecation warning pointing to properties {} block
- Add deprecated preserve<T>() extension for CreateDataFrameDsl
- Update preserve T test to use properties {} block instead of top-level preserve()
- Update generated sources and binary API file
- Add TRAVERSE_PROPERTIES_DSL deprecation message constant
Copilot
AI
changed the title
[WIP] Remove
Remove TraversePropertiesDsl from top-level toDataFrame {} operation
Jul 28, 2026
TraversePropertiesDsl from top-level toDataFrame {} operation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top-level
preserve()/exclude()calls insidetoDataFrame {}had broken semantics: they were supposed to apply to allproperties {}blocks but did not work reliably, and calling them without anyproperties {}block produced an empty DataFrame. The compiler plugin also never supported this notation.Changes
CreateDataFrameDsl<T>no longer extendsTraversePropertiesDsl—exclude()andpreserve()are no longer directly available at the top level oftoDataFrame {}CreateDataFrameDslImpl— removedTraversePropertiesDsl by configurationdelegationexclude(),preserve(), andpreserve<T>()are kept onCreateDataFrameDslwithDeprecationLevel.WARNING(→ ERROR in 1.1), forwarding to aproperties {}block to ease migrationapiDump; methods remain in bytecode for binary compatibilityMigration
TraversePropertiesDslfrom top-leveltoDataFrame {}operation #1857