fix: validate GroupBy nested sort paths - #2007
Open
mvanhorn wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route the public
GroupBy.sortByandGroupBy.sortByDescselector overloads through one internal validation flow, retaining their existing signatures and sorting behavior.GroupBy.sortBycurrently resolves selectors against both the individual group frames and the outer grouped dataframe withUnresolvedColumnsPolicy.Skip.Verify the valid nested path
pathOf("group", "group", "salary_in_usd")still sorts grouped salary rows in ascending and descending order; VerifyGroupBy.sortByandGroupBy.sortByDescboth rejectpathOf("group", "salaryInUsd")and report the missing nested path consistently, without the column-group sort-flag message.Fixes #780