Skip to content

fix: Fixes full screen images for title page - #236

Merged
RDMillen merged 2 commits into
KovaMD:mainfrom
florian-hubertSE:bugfix/title-page-full-screen-image
Sep 1, 2026
Merged

fix: Fixes full screen images for title page#236
RDMillen merged 2 commits into
KovaMD:mainfrom
florian-hubertSE:bugfix/title-page-full-screen-image

Conversation

@florian-hubertSE

@florian-hubertSE florian-hubertSE commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Fixes images on title screen

Before:

Screenshot 2026-08-31 164327

After:

![bg fit](https://img.magnific.com/fotos-kostenlos/nahaufnahme-eines-schoenen-schmetterlings-mit-interessanten-texturen-auf-einer-orangeblaettrigen-blume_181624-7640.jpg?semt=ais_hybrid&w=740&q=80)

image

or

![](https://img.magnific.com/fotos-kostenlos/nahaufnahme-eines-schoenen-schmetterlings-mit-interessanten-texturen-auf-einer-orangeblaettrigen-blume_181624-7640.jpg?semt=ais_hybrid&w=740&q=80)

image

or

using

![bg fit](https://img.magnific.com/fotos-kostenlos/nahaufnahme-eines-schoenen-schmetterlings-mit-interessanten-texturen-auf-einer-orangeblaettrigen-blume_181624-7640.jpg?semt=ais_hybrid&w=740&q=80)

image

@RDMillen RDMillen self-assigned this Sep 1, 2026
@RDMillen RDMillen added the bug Something isn't working label Sep 1, 2026
@RDMillen

RDMillen commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Hi @florian-hubertSE,

Thank you for submitting this fix, will get it pulled in for testing to go into the next release.

Ross

Drop the zero-diagram onAllDiagramsReady guard added here. It is
unrelated to showing a bg image behind a bare title slide, and the
same export-readiness change is being handled in KovaMD#235.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@RDMillen

RDMillen commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Thanks @florian-hubertSE. To land this quickly I have pushed a small follow-up commit:

  1. Dropped the zero-diagram onAllDiagramsReady guard from SlideRenderer.tsx. It is unrelated to the background-image fix, and the same export-readiness change is already part of fix: Fixes pdf export via cli (on windows) #235, so keeping it here would have left a duplicate hunk.
  2. Left the CSS change exactly as you wrote it.

Will merge once CI is green. Please keep #235 focused on the CLI export work.

@RDMillen
RDMillen merged commit 9753d2a into KovaMD:main Sep 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants