[HDF5] Add runtime hdf5 lib installation at the libs folder#14296
Open
sunethwarna wants to merge 1 commit intomasterfrom
Open
[HDF5] Add runtime hdf5 lib installation at the libs folder#14296sunethwarna wants to merge 1 commit intomasterfrom
sunethwarna wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR installs the dynamic library which was used at the linking time as well in the Kratos install directory. The stub generation of the HDF5 application in Windows was failing due to the fact that
hdf5.dllcould not be located. This PR fixes it.The
IMPORTED_RUNTIME_ARTIFACTSis a cmake 3.21 feature. This PR is also meant to check if the CI passes with cmake 3.21.🆕 Changelog