platform: add DMA support for the RPG family of flashcarts#163
Open
lifehackerhansol wants to merge 2 commits intoLNH-team:developfrom
Open
platform: add DMA support for the RPG family of flashcarts#163lifehackerhansol wants to merge 2 commits intoLNH-team:developfrom
lifehackerhansol wants to merge 2 commits intoLNH-team:developfrom
Conversation
Contributor
|
The dma patch code you added looks very similar. Can we avoid duplication? |
Contributor
Author
|
Not really, because of the different parameters each platform needs:
We could programmatically patch those instructions I suppose, but I haven't tried it. |
Contributor
I guess another option could be to create an .inc file with the code with some |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.