Skip to content

Create Mofcomp.yml#236

Closed
danielgottt wants to merge 8 commits into
LOLBAS-Project:masterfrom
danielgottt:patch-2
Closed

Create Mofcomp.yml#236
danielgottt wants to merge 8 commits into
LOLBAS-Project:masterfrom
danielgottt:patch-2

Conversation

@danielgottt

Copy link
Copy Markdown

Create lolbas yml entry for the Windows binary "mofcomp.exe". This relates to issue #137

Create lolbas yml entry for the Windows binary "mofcomp.exe". This relates to issue LOLBAS-Project#137
Added additional resources for detection via PowerShell etc
Correction to path's
@wietze wietze linked an issue Oct 4, 2022 that may be closed by this pull request
@wietze wietze requested a review from a team August 5, 2023 17:59
wietze and others added 4 commits August 5, 2023 19:14
@xenoscr

xenoscr commented Oct 7, 2023

Copy link
Copy Markdown
Contributor

I've fixed the YAML issues, this works, of course. @LOLBAS-Project/lolbas-team, this needs reviewed and it can be merged.

@josehelps josehelps self-assigned this Jun 29, 2026
@josehelps

Copy link
Copy Markdown
Contributor

@danielgottt this looks awesome overall, sorry it has taken me a minute to finalize review there are a handful of tiny items to tighten up:

  1. Capitalize the binary name in the Name field: mofcomp.exe to Mofcomp.exe (matches repo convention).
  2. Do you have Code samples? Might be nice to populate Code_Sample: field otherwise we can go with NA.
  3. Fix OperatingSystem casing: Windows vista to Windows Vista, and rephrase & Windows Server 2008 and above to a standard format like Windows Server 2008+ or explicit versions.
  4. The reference link ending in managed-object-format--mof- looks truncated .. can you please verify it?
  5. Add a Tags, eg Execute: WMI.

Happy to include these fixes myself, just get me the code sample if you happen to have any.

@josehelps

Copy link
Copy Markdown
Contributor

Closing in favor of a new PR with the reviewed/cleaned-up entry. Thanks @danielgottt for the original contribution!

@josehelps josehelps closed this Jun 29, 2026
@josehelps josehelps mentioned this pull request Jun 29, 2026
@josehelps

Copy link
Copy Markdown
Contributor

@danielgottt seeing this is about 3 years old decided to just fix it up and finally get it in, but did that under another PR still kept credit for you ofcourse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mofcomp.exe

4 participants