LibWeb/DOM: Collapse ranges before DOM mutations#8944
Merged
shannonbooth merged 1 commit intoLadybirdBrowser:masterfrom Apr 17, 2026
Merged
LibWeb/DOM: Collapse ranges before DOM mutations#8944shannonbooth merged 1 commit intoLadybirdBrowser:masterfrom
shannonbooth merged 1 commit intoLadybirdBrowser:masterfrom
Conversation
Member
|
Appears like https://github.com/web-platform-tests/wpt/blob/2ac434171d218b29a279abb17e4a9ba23a064366/dom/ranges/Range-extractContents-dynamic-end.html is the associated WPT for this |
Member
|
Which we pass already, maybe is actually the other linked test (currently still open) to that DOM MR? |
AtkinsSJ
force-pushed
the
collapse-dom-ranges
branch
from
fdec34d to
1adaf76
Compare
AtkinsSJ
force-pushed
the
collapse-dom-ranges
branch
from
1adaf76 to
3ba61ba
Compare
Member
Author
|
The tests in web-platform-tests/wpt#58008 also pass with or without the changes here, so I've left them. |
Member
|
Curious! |
The spec text has also changed since we implemented it, but moving when we collapse the range is the only actual behaviour change. Corresponds to: whatwg/dom@9363c6d
AtkinsSJ
force-pushed
the
collapse-dom-ranges
branch
from
3ba61ba to
10eb44f
Compare
Member
Author
|
Rebased to solve the rust-linting issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec text has also changed since we implemented it, but moving when we collapse the range is the only actual behaviour change.
Corresponds to:
whatwg/dom@9363c6d