Added this.rectMode support#29
Closed
sahej-dev wants to merge 3 commits into
Closed
Conversation
Owner
|
Hi there! I’m back! Thank you so much for your pull request. That said, I’m going to close it because I’ve changed the API while updating the library to p5.js 2.x, and p5.clickable no longer manages how clickables look, only their interactions. Thank you very much for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added support for all P5 rectModes. All the following are valid:
rectMode(CENTER) should no longer affect clickables.myButton.rectMode = CENTERmust be used.I have tried not to change up the existing structure of the library too much. Please let me know if I should make any further improvements/changes to this PR.