Skip to content

Expose Cmlx product + enable jaccl distributed backend #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupsv wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −8
Open

Expose Cmlx product + enable jaccl distributed backend #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,8 @@ let cmlx = Target.target(
// vendor docs
"vendor-README.md",

// example code + mlx-c distributed
// example code only (distributed C API now enabled)
"mlx-c/examples",
"mlx-c/mlx/c/distributed.cpp",
"mlx-c/mlx/c/distributed_group.cpp",

// vendored library, include header only
"json",
Expand Down Expand Up @@ -190,15 +188,13 @@ let cmlx = Target.target(
"mlx/mlx/backend/metal/kernels",
"mlx/mlx/backend/metal/nojit_kernels.cpp",

// do not build distributed support (yet)
// non-jaccl distributed backends: excluded
"mlx/mlx/distributed/mpi/mpi.cpp",
"mlx/mlx/distributed/ring/ring.cpp",
"mlx/mlx/distributed/nccl/nccl.cpp",
"mlx/mlx/distributed/nccl/nccl_stub",
"mlx/mlx/distributed/jaccl/jaccl.cpp",
"mlx/mlx/distributed/jaccl/mesh.cpp",
"mlx/mlx/distributed/jaccl/ring.cpp",
"mlx/mlx/distributed/jaccl/utils.cpp",
// jaccl stub excluded now that the real backend is built
"mlx/mlx/distributed/jaccl/no_jaccl.cpp",
],
cSettings: [
.headerSearchPath("mlx"),
Expand Down Expand Up @@ -226,6 +222,7 @@ let package = Package(

products: [
// main targets
.library(name: "Cmlx", targets: ["Cmlx"]),
.library(name: "MLX", targets: ["MLX"]),
.library(name: "MLXRandom", targets: ["MLXRandom"]),
.library(name: "MLXNN", targets: ["MLXNN"]),
Expand Down
2 changes: 2 additions & 0 deletions Source/Cmlx/include-framework/Cmlx.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
#include <Cmlx/mlx-device.h>
#include <Cmlx/mlx-distributed-distributed.h>
#include <Cmlx/mlx-distributed-ops.h>
#include <Cmlx/mlx-c-distributed_group.h>
#include <Cmlx/mlx-c-distributed.h>
#include <Cmlx/mlx-einsum.h>
#include <Cmlx/mlx-export.h>
#include <Cmlx/mlx-fast.h>
Expand Down