audit(aws): surface OpenSearch RI tag-failure for ops monitoring (closes #250)#831
audit(aws): surface OpenSearch RI tag-failure for ops monitoring (closes #250)#831cristim wants to merge 2 commits into
Conversation
#250) Emit a structured OPENSEARCH_TAG_FAILED log line when the best-effort AddTags call after RI purchase fails, so operator dashboards can alert on untagged reservations. Add runbooks/opensearch-untagged-ri.md with manual remediation steps and background on the unsupported ARN type. Update the PurchaseCommitment comment to reference the runbook.
|
@coderabbitai review |
|
Warning Review limit reached
More reviews will be available in 21 minutes and 24 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Actions performedReview triggered.
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
…lure (#831) The prior run failed because GitHub's CDN returned a 404 for the pinned actions/setup-go SHA at download time (transient infrastructure issue). No code changes are needed; this empty commit re-triggers CI.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
Rate Limit Exceeded
|
Summary
WARNING:log line inPurchaseCommitmentwith astructured
OPENSEARCH_TAG_FAILED commitment_id=<id> error=<msg>line sooperator dashboards and CloudWatch Logs Insights queries can alert on
untagged RIs
runbooks/opensearch-untagged-ri.mdcovering background (unsupportedreserved-instance ARN type), manual re-tagging steps, and the fallback for
when AWS still rejects the call
PurchaseCommitmentcomment to reference the runbookTest plan
TestPurchaseCommitment_TagFailure_StructuredLog(new): verifiesOPENSEARCH_TAG_FAILEDsentinel andcommitment_id=field appear in thelog, purchase result is still
Success=true, and account ID is absent fromthe line
TestClient_PurchaseCommitment_AddTagsFailureDoesNotFailPurchaseremains green (non-fatal contract unchanged)
go vet ./providers/aws/services/opensearch/...clean