Skip to content

fix(home/chart): Potential Savings by Service honors global filter#879

Open
cristim wants to merge 1 commit into
feat/multicloud-web-frontendfrom
fix/867-home-service-chart-filter
Open

fix(home/chart): Potential Savings by Service honors global filter#879
cristim wants to merge 1 commit into
feat/multicloud-web-frontendfrom
fix/867-home-service-chart-filter

Conversation

@cristim
Copy link
Copy Markdown
Member

@cristim cristim commented May 30, 2026

Summary

QA Main Header 2.10: Home page "Potential Savings by Service" chart ignored the Main Header global Provider/Account chips. The KPI cards (PR #755) and Savings-over-time chart (PR #747) on the same page already responded; the Service chart was the holdout.

Fix

The Service chart was rendered once on initial mount and never re-rendered on chip changes. Now subscribes to provider + account chip changes with the existing isHomeTabActive guard and queueMicrotask coalescing (mirrors PR #747), refilters the underlying data slice, and renders.

Filter-aware empty state: "No recommendations for " instead of showing the chart with $0 bars.

Files changed

  • frontend/src/dashboard.ts
  • frontend/src/__tests__/dashboard.test.ts

Test plan

  • 74 dashboard tests pass.
  • Manual: select Account/Provider chip, confirm Service chart filters consistently with the rest of the Home page.

Closes #867.

The chart re-rendered only on initial mount; chip changes were silently
ignored. Subscriptions now refilter the Service chart on provider /
account changes, mirroring PR #747's pattern.

Closes #867.
@cristim cristim added triaged Item has been triaged priority/p2 Backlog-worthy severity/medium Moderate harm urgency/this-sprint Within the current sprint impact/many Affects most users effort/s Hours type/bug Defect labels May 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 32 minutes and 16 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eb98857f-8a70-4ddf-aa14-b08100613397

📥 Commits

Reviewing files that changed from the base of the PR and between 4956d66 and 130c24b.

📒 Files selected for processing (2)
  • frontend/src/__tests__/dashboard.test.ts
  • frontend/src/dashboard.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/867-home-service-chart-filter

Comment @coderabbitai help to get the list of available commands and usage tips.

@cristim
Copy link
Copy Markdown
Member Author

cristim commented May 30, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/s Hours impact/many Affects most users priority/p2 Backlog-worthy severity/medium Moderate harm triaged Item has been triaged type/bug Defect urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant