fix(home/chart): Potential Savings by Service honors global filter#879
fix(home/chart): Potential Savings by Service honors global filter#879cristim wants to merge 1 commit into
Conversation
|
Warning Review limit reached
More reviews will be available in 32 minutes and 16 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
QA Main Header 2.10: Home page "Potential Savings by Service" chart ignored the Main Header global Provider/Account chips. The KPI cards (PR #755) and Savings-over-time chart (PR #747) on the same page already responded; the Service chart was the holdout.
Fix
The Service chart was rendered once on initial mount and never re-rendered on chip changes. Now subscribes to provider + account chip changes with the existing
isHomeTabActiveguard and queueMicrotask coalescing (mirrors PR #747), refilters the underlying data slice, and renders.Filter-aware empty state: "No recommendations for " instead of showing the chart with $0 bars.
Files changed
frontend/src/dashboard.tsfrontend/src/__tests__/dashboard.test.tsTest plan
Closes #867.