test(archera): extend federation handler matrix to CLI/ARM (closes #316)#890
test(archera): extend federation handler matrix to CLI/ARM (closes #316)#890cristim wants to merge 1 commit into
Conversation
Add table-driven test matrix for all CLI target/source combinations, ARM renders across source-cloud variants, single-file render shape invariants, and a dedicated Archera default-off regression guard. New tests: - TestGetFederationIaC_CLIMatrix: 8 target/source cases verifying content-type (text/x-shellscript), no ContentEncoding, bash shebang, canonical purchase+read actions for AWS-target, and no PII outside CONTACT_EMAIL assignment. - TestGetFederationIaC_ARMMatrix: 2 source variants verifying ARM JSON schema, parameters/resources/outputs structure, Reservation Purchaser role definition ID, no Archera references. - TestGetFederationIaC_SingleFileRenderShape: invariant that CLI renders are plain text with no base64 encoding. - TestGetFederationIaC_CLIArcheraDefaultOff: dedicated regression guard asserting Archera is absent from all 5 CLI formats by default.
cristim
added
triaged
|
Warning Review limit reached
More reviews will be available in 15 minutes and 35 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
1 participant
Summary
TestGetFederationIaC_CLIMatrix: table-driven test over all 8 CLI target/source combos asserting content-type, no ContentEncoding (single-file shape), bash shebang, canonical purchase+read actions for AWS-target, Archera default-off, and PII guard (email not leaked outside CONTACT_EMAIL assignment)TestGetFederationIaC_ARMMatrix: ARM render coverage for source=aws and source=gcp, asserting ARM JSON schema validity, parameters/resources/outputs structure, Reservation Purchaser role definition ID, no Archera references in any artifactTestGetFederationIaC_SingleFileRenderShape: invariant that CLI renders produce plain text with no base64/ContentEncodingTestGetFederationIaC_CLIArcheraDefaultOff: dedicated regression guard for all 5 CLI formatsTest plan
go test ./internal/api/... -run TestGetFederationIaC_CLIMatrix- 8 sub-cases passgo test ./internal/api/... -run TestGetFederationIaC_ARMMatrix- 2 sub-cases passgo test ./internal/api/... -run TestGetFederationIaC_SingleFileRenderShape- passesgo test ./internal/api/... -run TestGetFederationIaC_CLIArcheraDefaultOff- 5 sub-cases passgo test ./internal/api/...- all 1374 tests pass (no regressions)