Skip to content

docs(workflow): re-request CodeRabbit after every push, wait 10 min before triaging#21

Open
cristim wants to merge 1 commit into
mainfrom
docs/cr-rerequest-after-push
Open

docs(workflow): re-request CodeRabbit after every push, wait 10 min before triaging#21
cristim wants to merge 1 commit into
mainfrom
docs/cr-rerequest-after-push

Conversation

@cristim
Copy link
Copy Markdown
Member

@cristim cristim commented May 22, 2026

After every push to an open PR branch, re-request @coderabbitai review and at the same time arm a ~10-minute timer before reading/triaging CR comments, since CodeRabbit needs several minutes to post and triaging earlier just reads a stale or absent review.

  • cr-watch (§2) now waits ~10 min after the trigger before its first read, then polls 60-120s. Arm via ScheduleWakeup or a no-op-until-elapsed cron; don't block the session spinning.
  • Post-push callout: re-request CR and arm the timer together on every PR-branch push, not only at PR creation.
  • §3 re-ping: every fix push restarts the same give-CR-time clock.
  • CLAUDE.md post-PR headline echoes the rule.

Builds on the just-merged CR-pattern-memory work (#20).

Summary by CodeRabbit

  • Documentation
    • Refined post-PR review workflow documentation for CodeRabbit integration with clarified atomic step ordering and comprehensive timing requirements.
    • Enhanced background agent polling guidance with explicit ~10-minute initial wait periods and 60-120s interval polling specifications for consistency.
    • Improved rate limit error handling with detailed cooldown duration parsing for adaptive and reliable re-ping timing.

Review Change Stack

…efore triaging

After every push to an open PR branch, re-request @coderabbitai review and at
the same time arm a ~10-minute timer before reading or triaging CR comments,
since CodeRabbit needs several minutes to post and triaging earlier just reads
a stale or absent review.

- cr-watch (§2) now waits ~10 min after the trigger before its first read, then
  polls 60-120s; arm via ScheduleWakeup or a no-op-until-elapsed cron.
- Post-push callout: re-request CR and arm the timer together on every PR-branch
  push, not only at PR creation.
- §3 re-ping: every fix push restarts the same give-CR-time clock.
@cristim cristim added triaged Item has been triaged type/docs Documentation effort/xs Trivial / one-liner impact/internal Team-internal only severity/low Minor harm urgency/eventually No deadline priority/p3 Polish / idea / may never ship labels May 22, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 62f7aa5b-eb1e-4f09-a272-277f61045413

📥 Commits

Reviewing files that changed from the base of the PR and between 4f18d22 and c992e81.

📒 Files selected for processing (2)
  • CLAUDE.md
  • git-workflow.md

📝 Walkthrough

Walkthrough

Documentation refinements to the CodeRabbit post-PR review loop in CLAUDE.md and git-workflow.md enforce atomic watcher-trigger ordering, introduce ~10-minute triage delays after push, and add explicit handling for CodeRabbit rate-limit cooldown messages in the background polling agent.

Changes

CodeRabbit Review Loop Timing

Layer / File(s) Summary
Post-push timing and re-request flow
CLAUDE.md, git-workflow.md
After pushing to an open PR branch, CodeRabbit review must be re-requested and a ~10-minute triage timer armed simultaneously, with guidance clarified across both CLAUDE.md overview and git-workflow.md procedural steps.
Background agent polling and cooldown handling
git-workflow.md
The cr-watch background agent now waits ~10 minutes after the review trigger before its first poll, continues at 60–120s intervals, and explicitly handles CodeRabbit's rate-limit responses by parsing cooldown durations and re-pinging after that exact wait.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • LeanerCloud/dotclaude#1: Both PRs modify the CodeRabbit watcher/background-agent instructions in git-workflow.md and CLAUDE.md; this PR adjusts timing/polling/429-handling while the related PR changes model-tier behavior.
  • LeanerCloud/dotclaude#15: Both PRs update CodeRabbit PR loop documentation in CLAUDE.md/git-workflow.md; this PR refines watcher timing/polling while the related PR changes the model-tier (Opus vs. Sonnet) for fix-commit respawning.

Suggested labels

effort/s

Poem

🐰 The watcher thumps impatiently,
Waiting ten minutes, patiently—
Then polls at lightning speed,
Rate limits parsed with need,
CodeRabbit reviews now timed correctly! ⏱️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately summarizes the main change: updating workflow documentation to require re-requesting CodeRabbit after every push and waiting 10 minutes before triaging.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/cr-rerequest-after-push

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/xs Trivial / one-liner impact/internal Team-internal only priority/p3 Polish / idea / may never ship severity/low Minor harm triaged Item has been triaged type/docs Documentation urgency/eventually No deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant