Alex/implement email notification functionality by alexappleget · Pull Request #464 · LetsGetTechnical/gridiron-survivor

alexappleget · 2024-08-15T21:08:08Z

Closes #463

Create functionality for email notifications into the project for the admin notifications page.

ONCE this ticket gets merged in, I will create more tickets to implement more customization for sending emails. Ex: survivors only email, eliminated. For now, only participants is created to test that the email function does take in id's and sends an email.

Used Appwrite's Messaging in order to be able to send email notifications.
In order to use Appwrite Messaging we need an email provider that's compatible with Appwrite.
I went with Mailgun as the email provider because they have a free version for us for testing.
I connected Mailgun to Appwrite Messaging in order to use createEmail() for our code.
createEmail() from Appwrite is a backend only function, so I had to create a 'use server' action file to build out the client and create a function to use the createEmail() function inside of it.
Since createEmail() is a server function, I used form submission in order to get it to work on the frontend the way we want.
Did seperate testing for the client side and then for the server side because the server and client can't crossover.
Had to mock the server function inside the client testing because jest isn't configured to parse it.
All tests pass and the inputs send an email.

Recording.2024-08-19.143407.mp4

…ted imports alphabetically

…Technical/gridiron-survivor into ryan/create-admin-layout

…lative

… declared in the layout but the props can be updated per page

appwrite · 2024-08-15T21:08:12Z

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function	ID	Status	Action
Your function has been successfully deployed.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function	ID	Status	Action
userAuth	`6626fef885a9f630442b`	Ready	View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
Appwrite has a Discord community with over 16 000 members. Come join us!

vercel · 2024-08-15T21:08:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
gridiron-survivor	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2024 3:15pm
gridiron-survivor-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2024 3:15pm

…nality" and "origin/alex/implement-email-notification-functionality" Fix: Deleted userIDs from function to avoid getting spammed

…eated test file

…il-notification-functionality

…nality

…il-notification-functionality

…n-functionality' into alex/implement-email-notification-functionality

…il-notification-functionality

Closes #474 Enhance the user experience of the existing admin notification page to improve its formatting and usability. **Acceptance Criteria:** - [X] Review and redesign the layout of the admin notification page for better organization and clarity. - [X] Improve the visual hierarchy of notification elements for easier scanning and management. - [X] Ensure the design is consistent with the overall admin panel aesthetics. --- ## Video Demo https://github.com/user-attachments/assets/cc1e8a0e-45b0-4fbe-9972-2deb085525dc --------- Co-authored-by: Alex Appleget <alexappleget2014@gmail.com> Co-authored-by: Shashi Lo <362527+shashilo@users.noreply.github.com>

…nality

ryanfurrer

I pulled and ran this locally, and while I'm getting a POST 200, I do not see any on-screen confirmation that the email was sent

…il-notification-functionality

ryanfurrer

I am unable to test this; every time I navigate to /admin it redirects me to my leagues.

…il-notification-functionality

…for bcc emailing.

…he league info and then grab the targetIDs of the users.

…il-notification-functionality

…e accurate.

choir241 · 2024-11-11T17:50:47Z

+        textAreaRef.style.height = `${scrollHeight + offsetBorder}px`;
+      }
+    }
+  }, [textAreaRef, triggerAutoSize]);


What happens when we remove textAreaRef and/or triggerAutoSize from useEffect dependencies here?

If we don't need to re-render the component, this will cause unnecessary re-renders.

choir241 · 2024-11-11T17:51:45Z

+    if (textAreaRef) {
+      if (init) {
+        textAreaRef.style.minHeight = `${minHeight + offsetBorder}px`;
+        if (maxHeight > minHeight) {
+          textAreaRef.style.maxHeight = `${maxHeight}px`;
+        }


Are these if statement nestings necessary, or are there ways we can combine some of them into one if conditional?

This would be a question for Ryan. These were his changes made that got merged into my branch after approval.

…il-notification-functionality

shashilo · 2024-11-21T21:40:30Z

+        textAreaRef.style.height = `${scrollHeight + offsetBorder}px`;
+      }
+    }
+  }, [textAreaRef, triggerAutoSize]);


If we don't need to re-render the component, this will cause unnecessary re-renders.

shashilo · 2024-11-21T21:41:32Z

+   */
+  const getLeagueData = async (): Promise<void> => {
+    try {
+      const leagueId = '66f1a8e300102bff03ff'; // EMAIL TEST LEAGUE (DO NOT CHANGE)


Do we not have this dynamically working?

shashilo · 2024-11-21T21:42:07Z

+     * Fetches the league data.
+     * @returns The league data.
+     */
+    const fetchData = async (): Promise<void> => {


Does this need to be in a useEfect or can it just be called when the component mounts?

ryanfurrer and others added 13 commits August 2, 2024 15:28

feat((admin)/layout.tsx): began building out admin layout

66835c2

create admin layout

9049bfa

Merge branch 'develop' into ryan/create-admin-layout

5f3d9e5

feat(admin/layout.tsx): added classnames to future components and sor…

ac4c293

…ted imports alphabetically

Merge branch 'ryan/create-admin-layout' of https://github.com/LetsGet…

13ec1c6

…Technical/gridiron-survivor into ryan/create-admin-layout

(admin/layout.tsx): use alias import for errorboundary rather than re…

d4cfc88

…lative

refine admin layout and begin componetizing the layout elements

a0eafb5

refine components and pages for admin route

9bc34ef

Merge branch 'develop' into ryan/create-admin-layout

906e83f

attempt to add adminheader props to admin layout so the header can be…

e880373

… declared in the layout but the props can be updated per page

remove props from adminheader so the layout itself can be reviewed

9205f10

Merge branch 'develop' into ryan/create-admin-layout

f50fe0e

Feat: added in email notification functionality

b7685f7

alexappleget requested review from mhchen and shashilo as code owners August 15, 2024 21:08

vercel Bot deployed to Preview – gridiron-survivor-storybook August 15, 2024 21:08 View deployment

vercel Bot had a problem deploying to Preview – gridiron-survivor August 15, 2024 21:09 Failure

fix: removed unused optional props after users in the server action

621497e

vercel Bot had a problem deploying to Preview – gridiron-survivor August 15, 2024 21:25 Failure

vercel Bot deployed to Preview – gridiron-survivor-storybook August 15, 2024 21:26 View deployment

Auto stash before merge of "alex/implement-email-notification-functio…

85e48dd

…nality" and "origin/alex/implement-email-notification-functionality" Fix: Deleted userIDs from function to avoid getting spammed

vercel Bot deployed to Preview – gridiron-survivor-storybook August 15, 2024 21:33 View deployment

vercel Bot had a problem deploying to Preview – gridiron-survivor August 15, 2024 21:34 Failure

Fix: Added in comments to fix eslint error for sendEmailNotification()

0ce258f

vercel Bot deployed to Preview – gridiron-survivor-storybook August 15, 2024 21:38 View deployment

vercel Bot deployed to Preview – gridiron-survivor August 15, 2024 21:40 View deployment

Fix: Added participants prop to sendEmailNotification function and cr…

4f2709f

…eated test file

vercel Bot deployed to Preview – gridiron-survivor August 19, 2024 15:46 View deployment

alexappleget and others added 12 commits September 26, 2024 10:56

Fix: Fixed tests

b97e185

Fix: Hard coded bcc target id's

97f3ae8

Merge remote-tracking branch 'origin/develop' into alex/implement-ema…

368f41e

…il-notification-functionality

Merge branch 'develop' into alex/implement-email-notification-functio…

0d8d397

…nality

Merge remote-tracking branch 'origin/develop' into alex/implement-ema…

9605af5

…il-notification-functionality

Merge remote-tracking branch 'origin/alex/implement-email-notificatio…

6246c4f

…n-functionality' into alex/implement-email-notification-functionality

Fix: deleted target ID's

6a58f10

Fix: Fixed tests

8e3148a

Merge remote-tracking branch 'origin/develop' into alex/implement-ema…

9c864d5

…il-notification-functionality

Merge branch 'develop' into alex/implement-email-notification-functio…

e85408c

…nality

Merge branch 'develop' into alex/implement-email-notification-functio…

b4f7874

…nality

ryanfurrer requested changes Oct 14, 2024

View reviewed changes

alexappleget added 3 commits October 18, 2024 09:43

Merge remote-tracking branch 'origin/develop' into alex/implement-ema…

b12ea64

…il-notification-functionality

Merge remote-tracking branch 'origin/develop' into alex/implement-ema…

3e2aadd

…il-notification-functionality

Fix: Changed leagueId to email testing league.

247a786

ryanfurrer requested changes Oct 28, 2024

View reviewed changes

alexappleget added 8 commits November 5, 2024 09:10

Merge remote-tracking branch 'origin/develop' into alex/implement-ema…

1188d47

…il-notification-functionality

Fix: Created an api function to convert userIDs into their targetIDs …

e55c39f

…for bcc emailing.

Fix: Updated the fetch league data function to now be able to fetch t…

8eb3bd6

…he league info and then grab the targetIDs of the users.

Fix: Updated sendEmailNotification function test.

f4e006c

Merge remote-tracking branch 'origin/develop' into alex/implement-ema…

0641f59

…il-notification-functionality

Fix: Changed file and folder names.

aa4c65d

Fix: fixed testing errors and changed errors to throw error to be mor…

5119a15

…e accurate.

Fix: changed mock import to fix test.

1717433

choir241 reviewed Nov 11, 2024

View reviewed changes

alexappleget added 2 commits November 12, 2024 12:51

Merge remote-tracking branch 'origin/develop' into alex/implement-ema…

d207ea0

…il-notification-functionality

Merge remote-tracking branch 'origin/develop' into alex/implement-ema…

7bf57bb

…il-notification-functionality

shashilo requested changes Nov 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Alex/implement email notification functionality#464

Alex/implement email notification functionality#464
alexappleget wants to merge 69 commits into
developfrom
alex/implement-email-notification-functionality

alexappleget commented Aug 15, 2024 •

edited

Loading

Uh oh!

appwrite Bot commented Aug 15, 2024 •

edited

Loading

Uh oh!

vercel Bot commented Aug 15, 2024 •

edited

Loading

Uh oh!

ryanfurrer left a comment

Uh oh!

ryanfurrer left a comment

Uh oh!

choir241 Nov 11, 2024

Uh oh!

shashilo Nov 21, 2024

Uh oh!

choir241 Nov 11, 2024

Uh oh!

alexappleget Nov 21, 2024

Uh oh!

shashilo Nov 21, 2024

Uh oh!

shashilo Nov 21, 2024

Uh oh!

shashilo Nov 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

alexappleget commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

appwrite Bot commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ryanfurrer left a comment

Choose a reason for hiding this comment

Uh oh!

ryanfurrer left a comment

Choose a reason for hiding this comment

Uh oh!

choir241 Nov 11, 2024

Choose a reason for hiding this comment

Uh oh!

shashilo Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

choir241 Nov 11, 2024

Choose a reason for hiding this comment

Uh oh!

alexappleget Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

shashilo Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

shashilo Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

shashilo Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alexappleget commented Aug 15, 2024 •

edited

Loading

appwrite Bot commented Aug 15, 2024 •

edited

Loading

vercel Bot commented Aug 15, 2024 •

edited

Loading