Skip to content

feat: Adds a package trait to turn off the support for LaTeX #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LiYanan2004 merged 3 commits into from
Mar 14, 2026
Merged

feat: Adds a package trait to turn off the support for LaTeX #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2d1a43
feat: package trait for latex
TizianoCoroneo Mar 11, 2026
493d2f7
chore: added latex to default traits
TizianoCoroneo Mar 11, 2026
a3cd270
fix: removed extra trait declaration on LaTeXSwiftUI
TizianoCoroneo Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// swift-tools-version: 6.0
// swift-tools-version: 6.2
// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription
Expand All @@ -15,6 +15,10 @@ let package = Package(
products: [
.library(name: "MarkdownView", targets: ["MarkdownView"]),
],
traits: [
"LaTeX",
.default(enabledTraits: ["LaTeX"])
Comment on lines +19 to +20
Copy link
Copy Markdown
Contributor Author

@TizianoCoroneo TizianoCoroneo Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first line declares a package trait, the second makes sure that the trait is enabled by default to keep compatibility with the current behavior.

],
dependencies: [
.package(url: "https://github.com/swiftlang/swift-markdown.git", from: "0.5.0"),
.package(url: "https://github.com/raspu/Highlightr.git", from: "2.2.1"),
Expand All @@ -36,7 +40,7 @@ let package = Package(
.product(
name: "LaTeXSwiftUI",
package: "LaTeXSwiftUI",
condition: .when(platforms: [.iOS, .macOS])
condition: .when(platforms: [.iOS, .macOS], traits: ["LaTeX"])
Copy link
Copy Markdown
Contributor Author

@TizianoCoroneo TizianoCoroneo Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one makes sure that this package is only included if the trait is enabled.

),
],
swiftSettings: [.swiftLanguageMode(.v6)]
Expand Down
2 changes: 1 addition & 1 deletion Sources/MarkdownView/WIP/MarkdownTextNode.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ extension MarkdownTextNode {
)
)
default:
return Text("Unimplemented: \(kind)")
Copy link
Copy Markdown
Contributor Author

@TizianoCoroneo TizianoCoroneo Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line just fixes a warning.

return Text("Unimplemented: \(String(describing: kind))")
}
}
}
Loading