Modernize repository - #212
Conversation
This starts the CI, dependency, and build modernization, targeting the shared modernize-repository branch @jitsedesmet set up upstream. Covers: GitHub Actions bumped to non-deprecated versions targeting Node.js 24, Docker base image updated to node:22-slim, HDT's native build fixed for modern Node, sinon/sinon-chai modernization attempted then reverted (pinned sinon-chai to 2.14.0 instead the newer sinon API broke stub.reset() usage elsewhere), and lerna pinned to a version that keeps HDT's native build working at the root.
rubensworks
left a comment
rubensworks
left a comment
There was a problem hiding this comment.
Just one minor question, looks good otherwise!
| "eslint": "^7.0.0", | ||
| "eslint-plugin-import": "^2.22.0", | ||
| "lerna": "^4.0.0", | ||
| "lerna": "9.0.7", |
There was a problem hiding this comment.
Is there a reason why this is pinned? (not using ^)
There was a problem hiding this comment.
lerna was bumped 4 -> 9.0.7 to fix hdt's native build, i fixed the issue on the Typescript branch, kept lerna at ^4.0.0 and solved the same hdt/node-gyp problem with an explicit node-gyp: ^11.0.0 devDependency instead. So we can revert this change
There was a problem hiding this comment.
Do you mean reverting it here in this branch (before the PR is merged)?
Or will be be reverted later on in the other PR?
There was a problem hiding this comment.
will be be reverted later on in the other PR
There was a problem hiding this comment.
Ok! Then this PR should be good to go. @jitsedesmet do you agree if I merge this one?
There was a problem hiding this comment.
Yes, We can merge this (but not squash). Then we can just target main directly from now on?
There was a problem hiding this comment.
Done! Ok to target master from now on.
3 participants
Feature branch that will be rebased onto master when modernization is done.
Aims to close #206
This work is ongoing by @Michiel-VandeVelde