Support {:else} blocks in @first, @last#143
Open
claviska wants to merge 3 commits into
Open
Conversation
Author
|
Not sure why the Travis build is failing, but the error seems unrelated. Any ideas? |
sethkinast
suggested changes
Jan 29, 2017
sethkinast
left a comment
Contributor
There was a problem hiding this comment.
For style purposes, could you follow the pattern in the filter function with skip and nonternary return values?
Contributor
|
The helpers build uses loose versioning for the Jasmine dep and it's changed out from under you, not your fault. Would you mind adding a test? Once this is merged you can open a PR against the gh-pages branch of the main Dust repo for the docs. Thanks a bunch for the PR! |
Author
|
Thanks. The format is consistent now and I added two tests. They're my first unit tests so feel free to suggest changes. 🙃 |
Contributor
|
Nice, thanks for taking the time to send a PR! :) |
Contributor
|
@jimmyhchan #138 will fix the test failures, I'll try to work on it soon... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple PR to add support for
{:else}in@firstand@lasthelpers, per linkedin/dustjs#720.575 tests, 837 assertions, 0 failures, 0 skipped