hal: Update inihal, halui and motion-logger to getter/setter - #4285
Open
BsAtHome wants to merge 1 commit into
Open
hal: Update inihal, halui and motion-logger to getter/setter#4285BsAtHome wants to merge 1 commit into
BsAtHome wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversion of inihal and halui are quite straight forward albeit many pins. The challenge is in the dual use of the structure construct where it both handled creation of the version in HAL memory with the pins and a copy structure using the underlying types.
There is a caveat where the code needs to change when we do the 64-bit cleanup. The expansion used with the macros is based on concatenation and both 32-bit and 64-bit integers are using the same hal type (hal_[su]int_t), but the getter/setter is called hal_[gs]et_[us]i32(). The sint/uint vs ui32/si32 mismatch is solved by a temporary typedef, but that excludes using both 64- and 32-bit versions simultaneously because the compiler would see the overlap and complain. There are at present no 64-bit pins in these components so the problem is not serious and should solve itself when we do the 64-bit cleanup.
The motion-logger update is rather trivial.