Add a configurable endpoint rate-limiter - #1116
Open
Toastbrot236 wants to merge 23 commits into
Open
Conversation
…tional warnings instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports Bunkum's
RateLimiterand modifies it in a way where, instead of getting its bucket data from hard-coded constants, it instead gets the data from a config file namedendpointRateLimits.json. This PR only implements and generally tests this rate-limiter, and only makes 3 endpoints use this new rate-limiter (for testing purposes), however, after this PR, I'd like to do follow-up PRs where I make all our endpoints use this new rate-limiter.There are mainly 2 reasons why we want configurable rate-limits:
Also, I'm not exactly sure how we'd want to handle migrations in the future where we want to update the default values of existing buckets. Should we just keep this one
OverwriteBucketValuesIfDefaultsAreUpdatedconfig flag, or should we have such a flag for every bucket separately?